Prevent focus trap in Legacy Widget block’s preview iframe #33614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +11 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy widgets currently break upward traversing of the block list by keyboard. The preview iframe ends up trapping the focus. This PR fixes it by adding
tabIndex="-1"on the iframe element.How has this been tested?
Using the arrow keys to traversing the block list in Customizer.
Screenshots
Before
getting stuck while attempting to move upward past the Meta Legacy Widget.
legacy-widget-focus-trap.mp4
After
keyboarding upward past the Meta Legacy Widget
legacy-widget-focus-flow.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).