Most Used Terms: Avoid 403 error for non-administrators #33569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
Jul 20, 2021
| @@ -33,7 +34,7 @@ export default function MostUsedTerms( { onSelect, taxonomy } ) { | |||
| ); | |||
| return { | |||
| _terms: mostUsedTerms, | |||
| showTerms: mostUsedTerms?.length >= MAX_MOST_USED_TERMS, | |||
| showTerms: mostUsedTerms?.length === MAX_MOST_USED_TERMS, | |||
There was a problem hiding this comment.
Updated check as suggested here - #33457 (comment)
|
Size Change: +7 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jul 20, 2021
|
Thanks for the review, @ntsekouras. |
|
Should this be included in 5.8.1 along with #33457? Adding the label for tracking, but please remove if this is not the case. |
|
@Mamaduka Thanks! Let's leave this one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The editor will trigger a 403 error when trying to fetch the most used terms for non-administrator users. This PR fixes this by setting the
contextparam toview.How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).