Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion List: Check if a node exists to scroll into view #33419

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Suggestion List: Check if a node exists to scroll into view #33419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/components/src/form-token-field/suggestions-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ class SuggestionsList extends Component {
componentDidUpdate() {
// only have to worry about scrolling selected suggestion into view
// when already expanded
if ( this.props.selectedIndex > -1 && this.props.scrollIntoView ) {
if (
this.props.selectedIndex > -1 &&
this.props.scrollIntoView &&
this.list.children[ this.props.selectedIndex ]
) {
this.scrollingIntoView = true;
scrollIntoView(
this.list.children[ this.props.selectedIndex ],
Expand Down