Rich text: run input rules after composition end #33416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1f8ac0 to
5a29414
Compare
5a29414 to
e17f5af
Compare
|
Size Change: +35 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Jul 14, 2021
| @@ -451,4 +451,19 @@ describe( 'RichText', () => { | |||
| await page.keyboard.press( 'ArrowLeft' ); | |||
| expect( await page.$( blockToolbarSelector ) ).toBe( null ); | |||
| } ); | |||
|
|
|||
| it( 'should run input rules after composition end', async () => { | |||
There was a problem hiding this comment.
I recommend adding a comment here about Puppeteer's lack of support for composition events and a link to puppeteer/puppeteer#4981, so that we can track it and as justification for the fact that this isn't a user-centred test.
|
Works for me, thanks for the fix. |
youknowriad
pushed a commit
that referenced
this pull request
Jul 15, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 15, 2021
gwwar
pushed a commit
that referenced
this pull request
Jul 19, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33004.
Introduced by #31752 (thanks @mcsf).
Input rules used to run after
compositionend, but that's no longer the case.It's not possible to make an e2e test for this because Puppeteer doesn't have any APIs around it. I filed a request in the past: puppeteer/puppeteer#4981.
How has this been tested?
Change to a keyboard with
`as a dead key and try to wrap text in it to wrap it in a code element.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).