Interface: Update content z-index #33415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content z-index should be higher than a sidebar. It prevents Snackbar notices from appearing behind the block inserter.
|
@youknowriad I realized there was a simpler fix for this issue while working on a new landmark region for notices. |
|
Size Change: -2 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
7 tasks
|
This breaks block preview in the inserter 😬 |
Thanks for catching this. I knew I missed something. 😅 I'll continue work on the new "notices" landmark region like we discussed yesterday. |
|
Closing this in favor of #33355. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33114.
Alternative to #33355.
The content z-index should be higher than a sidebar. It prevents Snackbar notices from appearing behind the block inserter.
I wasn't able to spot any regressions caused by changing the
.interface-interface-skeleton__contentz-index. It was initially introduced to prevent background bleed on Safari iOS on small viewports - #32631. I also noticed that without z-index Snackbars work as expected, so I think this is when the bug was introduced.How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).