Upgrade puppeteer to 10.1 #33327
Merged
Upgrade puppeteer to 10.1 #33327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
gziolo
reviewed
Jul 9, 2021
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Breaking Changes | |||
|
|
|||
| - Upgrade `puppeteer-core` (`^9.0.0`) to version `^10.1.0`. This version drops support for Node v10. | |||
There was a problem hiding this comment.
gutenberg/packages/scripts/package.json
Lines 21 to 24 in d0a25e8
@wordpress/scripts doesn't support Node v10 for quite some time already.
|
Seems like some tests are failing:
The last three I think have known issues in trunk already. I wonder if the widget customizer failures might be related to an incompatibility with puppeteer-testing-library. For the image tests, it seems like the data URL is suddenly different. Might be related to the newer chromium version, will investivate. Updates:
|
talldan
commented
Jul 12, 2021
| @@ -1,16 +1,16 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`Image allows changing aspect ratio using the crop tools 1`] = `"data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAMCAgICAgMCAgIDAwMDBAYEBAQEBAgGBgUGCQgKCgkICQkKDA8MCgsOCwkJDRENDg8QEBEQCgwSExIQEw8QEBD/2wBDAQMDAwQDBAgEBAgQCwkLEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBD/wAARCAAKAAoDASIAAhEBAxEB/8QAFQABAQAAAAAAAAAAAAAAAAAACQf/xAAgEAAAAwkBAAAAAAAAAAAAAAAABAUBAwYJNTh0d7K1/8QAFAEBAAAAAAAAAAAAAAAAAAAAAP/EABQRAQAAAAAAAAAAAAAAAAAAAAD/2gAMAwEAAhEDEQA/AJTJUuninX570U4K8rVU7kPOmgoZKl08U6/PeinBXlaqnch500B//9k="`; | |||
| exports[`Image allows changing aspect ratio using the crop tools 1`] = `"data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/4gIoSUNDX1BST0ZJTEUAAQEAAAIYAAAAAAIQAABtbnRyUkdCIFhZWiAAAAAAAAAAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAAHRyWFlaAAABZAAAABRnWFlaAAABeAAAABRiWFlaAAABjAAAABRyVFJDAAABoAAAAChnVFJDAAABoAAAAChiVFJDAAABoAAAACh3dHB0AAAByAAAABRjcHJ0AAAB3AAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAFgAAAAcAHMAUgBHAEIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFhZWiAAAAAAAABvogAAOPUAAAOQWFlaIAAAAAAAAGKZAAC3hQAAGNpYWVogAAAAAAAAJKAAAA+EAAC2z3BhcmEAAAAAAAQAAAACZmYAAPKnAAANWQAAE9AAAApbAAAAAAAAAABYWVogAAAAAAAA9tYAAQAAAADTLW1sdWMAAAAAAAAAAQAAAAxlblVTAAAAIAAAABwARwBvAG8AZwBsAGUAIABJAG4AYwAuACAAMgAwADEANv/bAEMAAwICAgICAwICAgMDAwMEBgQEBAQECAYGBQYJCAoKCQgJCQoMDwwKCw4LCQkNEQ0ODxAQERAKDBITEhATDxAQEP/bAEMBAwMDBAMECAQECBALCQsQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEP/AABEIAAoACgMBIgACEQEDEQH/xAAVAAEBAAAAAAAAAAAAAAAAAAAJB//EACAQAAADCQEAAAAAAAAAAAAAAAAEBQEDBgk1OHR3srX/xAAUAQEAAAAAAAAAAAAAAAAAAAAA/8QAFBEBAAAAAAAAAAAAAAAAAAAAAP/aAAwDAQACEQMRAD8AlMlS6eKdfnvRTgrytVTuQ86aChkqXTxTr896KcFeVqqdyHnTQH//2Q=="`; | |||
There was a problem hiding this comment.
The tests are still correct, it looks like the encoding for data URIs will change. I guess we can look forward to really long data URIs in chrome 92 🤔
It would be an option to update these tests to use image comparison.
There was a problem hiding this comment.
If we are testing aspect ratio, why didn't we just test the width and height of the image?
There was a problem hiding this comment.
I think it's still good to test the contents of the image to make sure the right part is being cropped. That said, the test image might not be producing the best results as it's a very uniform image.
1482830 to
3f5c2f2
Compare
|
Now just seeing the widgets test fail because it uses the search block, which seems to have a legitimate bug. It triggers this warning: Not sure why this isn't causing test failures in |
7 tasks
|
Search block issues are now fixed by #33376. |
3f5c2f2 to
1a1e3d7
Compare
|
Tests all passing now, so this should be good to ship. |
kevin940726
approved these changes
Jul 13, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the puppeteer dependency of the scripts package to 10.1.
This version drops support for Node v10 as a breaking change, which I think is ok (https://github.com/puppeteer/puppeteer/releases/tag/v10.0.0). Not sure if the scripts package was supporting it anyway.
It drastically improves support for testing drag and drop, it makes it considerably easier and will result in more robust drag and drop tests. And hopefully more tests too. (https://github.com/puppeteer/puppeteer/releases/tag/v10.1.0).
An example of the new drag and drop API - https://github.com/WordPress/gutenberg/pull/33320/files#diff-abafbd977989cfde20d9896c3e7a31524ac748e4ad55138a8e1ed88c192ce7c5R11-R57