Image block: fix replace link control styling #33326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +27 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
This comment has been minimized.
This comment has been minimized.
getdave
commented
Jul 9, 2021
|
@javierarce a quick 👀 from a design perspective would be good here if you have any time. |
|
This looks much better, @getdave. I just saw a couple of things:
I also discovered that if you enter a Base64 encoded image, the URL that appears in the
|
draganescu
approved these changes
Jul 9, 2021
|
Thanks for the review @javierarce!
I've added a consistent 8px margin in both edit and preview mode.
Removed that.
I set a hardcoded 200px width which avoids this.
I don't think we should attempt to "fix" this here but in a follow up. Essentially we do have much more data available but it's not being passed to the component so it isn't being displayed.
I think that should be resolved by the fixed width above. |
…renders by default This preserves the existing functionality of the control.
As requested by designer in #33326 (comment)
f8dfeda to
691f276
Compare
|
Rebasing FTW |
|
The changes look good to me! 🚀
Ok! |
|
Tests failing probably needs a rebase. Please could someone merge this so it makes 11.1 RC? |
|
@getdave this works as expected. Fine for me :). Thanks |
|
Tests finally passed. I didn't do anything so I guess these were upstream issues on |
|
@youknowriad This might be a good one for cherry picking in cc @gwwar who I think is shadowing the release. |
|
Changed the milestone to consider cherry-picking this. |
|
Thanks @youknowriad. Wasn't sure whether to go ahead and do that without confirming with the release lead first. |
gwwar
pushed a commit
that referenced
this pull request
Jul 19, 2021
* Conditionalise display of wrapping “tools” div * Align items visually to top of control below “Current media URL:” text * Extract default settings to root component scope to ensure tools div renders by default This preserves the existing functionality of the control. * Add space between label and input As requested by designer in #33326 (comment) * Fix popover resizing when switching between edit and preview mode
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The DOM and styling updates to
<LinkControl>necessitated by the introduction of the the rich link previews feature caused the Image blockReplaceflow dropdown to suffer a visual layout regression.This PR resolves this by aligning everything nicely again. See screenshots below.
Fixes #33096
How has this been tested?
Replaceon the Image block.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).