Latest posts: Remove grey color for dark themes #33325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this, I'm not sure if it will break anything for classic themes that aren't supplying styles for the block. If that were the case, I'd say defaulting to the same gray when there's no variable for body color could do the trick too for block themes. I still prefer this approach personally. |
|
Size Change: -14 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Jul 9, 2021
aristath
approved these changes
Jul 12, 2021
0ff19df to
d20fa78
Compare
d20fa78 to
69f9a45
Compare
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the grey color from post date and and post author text, so that it looks ok on dark themes.
Originally raised in Automattic/themes#4169
How has this been tested?
In emptytheme
Screenshots
Before:
After:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).