RNMobile: Add integration test to verify button block border radius functionality #33211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.33 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
36f4c33 to
344a354
Compare
The test should assert the existance of a React element but because of a missing `await`, was instead asserting an unresolved Promise instead. Since the unresolved Promise is a value, `toBeDefined` was returning `true` and the test was passing. Fixing the test involves resolving the Promise using `await` so that what's asserted is an actual React element.
|
I noticed when running the integration test that the following console error is logged: I think it was caused by the gutenberg/test/native/setup.js Line 199 in cb25fef However, per the original code, we should return a JSX element: |
I fixed the issue in this commit. |
|
An important thing that we should keep an eye on is the integration tests duration, for this case, the duration is around |
|
Thanks for fixing that console error. I'd seen it but hadn't checked if it was new or not.
I'll keep an eye on this. While the tests themselves are quick, the entire execution time (from when I execute the command till when it finishes) is quite long. I see 59.19 seconds for a run of a single test. |
7 tasks
I think it was introduced when I added the
I experienced the same, however, in the CI, running all the tests take less time 😄 (probably thanks to the Jest cache): Buttons block - Integration test: |
enejb
pushed a commit
that referenced
this pull request
Jul 17, 2021
…unctionality (#33211) * Add setup for button radius test * Tweak query in test * Clean up bottons tests * Clean up buttons test further * RNMobile: Fix reusable block test assertion The test should assert the existance of a React element but because of a missing `await`, was instead asserting an unresolved Promise instead. Since the unresolved Promise is a value, `toBeDefined` was returning `true` and the test was passing. Fixing the test involves resolving the Promise using `await` so that what's asserted is an actual React element. * Update useResizeObserver mock Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[NEW] Button block border radius tests
Adds a test to the button block on mobile to ensure button radius changes are saved properly. Fixes wordpress-mobile/gutenberg-mobile#3667.
[BUGFIX] Reusable block tests
The test should assert the existence of a React element but because of a missing
await, was instead asserting an unresolved Promise instead. Since the unresolved Promise is a value,toBeDefinedwas returningtrueand the test was passing.Fixing the test involved resolving the Promise using
awaitso that what's asserted is an actual React element.How has this been tested?
[NEW] Button block border radius tests
[BUGFIX] Reusable block tests
Run the test and ensure it passes:
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).