Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link color control to list block #33185

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Add link color control to list block #33185

merged 1 commit into from
Jul 6, 2021

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Jul 3, 2021 •
edited
Loading

Description

Fixes #33181 by adding link color to block support in block.json.

How has this been tested?

Tested by manually adding a list block and changing the link color.

Screenshots

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@carolinan carolinan added the [Block] List Affects the List Block label Jul 3, 2021
@carolinan carolinan requested a review from ajitbohra as a code owner July 3, 2021 03:30
jorgefilipecosta
jorgefilipecosta approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carolinan carolinan merged commit 3075e4f into trunk Jul 6, 2021
@carolinan carolinan deleted the add/list-link-color branch July 6, 2021 06:50
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 6, 2021
@richtabor
Copy link
Member

Awesome, thanks @carolinan! 👏👏

sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
@carolinan @sarayourfriend
Add link color control to list block (#33185)
d26eac2
@priethor priethor mentioned this pull request Jul 19, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] List Affects the List Block
Projects
None yet
Milestone
Gutenberg 11.1
Development

Successfully merging this pull request may close these issues.

Add link color support to the List block
3 participants
@carolinan @richtabor @jorgefilipecosta