components: Add useLatestRef hook #33137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
|
I've seen 3 variations of this hook:
|
diegohaz
reviewed
Jul 1, 2021
|
Thanks so much, Diego! I'll update the tests with your suggested changes now. |
2e8b22d to
012425e
Compare
diegohaz
reviewed
Jul 2, 2021
There was a problem hiding this comment.
Made some suggestions, but we should collect better (and valid) use cases to use as examples in the JSDocs and tests. I'm having trouble trying to create a simple example. I made this CodeSandbox trying to explain how this useLatestRef works in case it helps others.
EDIT: Updated the CodeSandbox and it's a bit more simple now, so maybe we can use something like that (debounce) in the tests.
07d5a14 to
5d95615
Compare
diegohaz
approved these changes
Jul 7, 2021
5d95615 to
413764b
Compare
Co-authored-by: Haz <hazdiego@gmail.com>
413764b to
90f09cd
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'll be honest, I have no idea how to use this or what it does exactly, or what value it brings us. The examples in the JSDoc are not at all helpful to me. If anyone has any suggestions for how to test this thing please let me know (it's used by TextInput so we need to add it one way or another).
How has this been tested?
I added a unit test, but it honestly just demonstrates the existing behavior. I have no idea what else to test.
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).