Add a label for screen reader in categories block #33060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Hug0-Drelon! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
youknowriad
approved these changes
Jun 29, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a label for screen reader when rendering a category block in dropdown mode.
Fixes this issue https://core.trac.wordpress.org/ticket/53510
How has this been tested?
Tested in WP5.7.2 with Gutenberg 10.9.
Environment :
I tested manually and it seems to work fine.
I ran the tests suite locally but I experienced some trouble both with the trunk branch and my new one, but the errors doesn't seems related to this fix.
Types of changes
Changes have been made in
package/block-library/src/categories/index.phpmodifying the dropdown attributes.Checklist: