Try: Small chevron icon for breadcrumb separators. #33042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +150 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
Good idea! |
|
Subtle, but so much nicer, @jasmussen |
|
Checks are passing if anyone wants to give a ✅ 😊 |
|
Tested with WordPress beta 4. With the Gutenberg plugin not activated.
With the special PR version of the Gutenberg plugin activated.
Looks good! To me it looks ready to go. |
|
Hey 👋 thanks for working on this @jasmussen - while the design is better here, the implementation is a bit wrong unfortunately. A couple of things that need to be fixed:
|
|
Ack, what a rookie mistake on my part, sorry about that. As it is, my Friday is looking tricky and I don't know if I can address it there. If you have time to help me fix it or revert it, I'd be grateful and owe you one. |
Sure I'll create a PR soon 😄 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The breadcrumb bar uses → for the separators, like so:
This PR replaces them with chevrons, for just a little bit more DNA shared with the list view:
Like so:
Here it is in action:
The RTL fix has been ported as well:
How has this been tested?
Test a document with lots of nesting, observe the chevron in the breadcrumb bar. Test also RTL languages.
Checklist:
*.native.jsfiles for terms that need renaming or removal).