Refactor the user autocompleter to avoid apiFetch and rely on the data module #33028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8996a7 to
8c5104a
Compare
|
Size Change: +1 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jun 28, 2021
|
Each time I restart the e2e tests, I have a different failure :( |
This method is called "e2e testing roulette." |
8c5104a to
f204a35
Compare
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can rely on the data module to make "view" context requests, we can start removing the adhoc usage of apiFetch across the codebase, making our packages more WP agnostic.
This PR does so for the user auto-completer.
Testing instructions
@username) works as expected