Focus style followup. #33022
Merged
Focus style followup. #33022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -15 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
gwwar
approved these changes
Jun 28, 2021
Thanks for the nudge. In testing before I overlooked an issue with the icon buttons now being illegible. Here's the unselected block before:
Now selected — observe no difference in focus style:
Unselected after this PR is identical:
But the selected state, after, is now visibly different with a thicker focus style:
As you can see from the above, the icon buttons are illegible. I'll open a separate PR to address that. |
7 tasks
|
Followup here: #33062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #32927 which applies the same fix to the appender focus style.
Before:
After:
How has this been tested?
Insert an empty group block and arrow-key into it to select it. Observe a consistent border width on all 4 sides.
Checklist:
*.native.jsfiles for terms that need renaming or removal).