[Block Library - Categories]: Fix crash when trying to access categories on insertion #32989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jun 25, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
…ies on insertion (#32989)
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
…ies on insertion (#32989)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when trying to insert
Categoriesblock in a post where the same block doesn't exist, therefore the request happens for the first time, It can lead sometimes to have theisRequestingvalue tofalseand thecategoriestonullat the first render. This PR adds optional chaining where needed, so we can avoid the block crash.categories-block.mov