-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-publish setting copy #32874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Copy
Issues or PRs that need copy editing assistance
[Feature] Saving
Related to saving functionality
labels
Jun 22, 2021
talldan
added
the
Needs Copy Review
Needs review of user-facing copy (language, phrasing)
label
Jun 22, 2021
Size Change: +2 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Hi @talldan, thanks for the copy review ping! This looks fine. |
talldan
removed
the
Needs Copy Review
Needs review of user-facing copy (language, phrasing)
label
Jun 23, 2021
noisysocks
approved these changes
Jun 23, 2021
kevin940726
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Saving
Related to saving functionality
[Type] Copy
Issues or PRs that need copy editing assistance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the copy of the pre-publish setting. This was referring to being able to change categories in the pre-publish panel, but from what I can tell that isn't possible:
I've changed it to refer to 'visibility' instead. Also added a comma before 'such as', from what I understand that's convention.
I also considered changing it to 'Review settings before publishing', but that does make the text a bit long.
Screenshots
Types of changes
Copy
Checklist:
*.native.js
files for terms that need renaming or removal).