-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Recursively clear node modules when building for ci #32856
Merged
sarayourfriend
merged 1 commit into
trunk
from
fix/clean-recursive-node-modules-compressed-size-check
Jun 23, 2021
Merged
CI: Recursively clear node modules when building for ci #32856
sarayourfriend
merged 1 commit into
trunk
from
fix/clean-recursive-node-modules-compressed-size-check
Jun 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
the
[Type] Bug
An existing feature does not function as intended
label
Jun 21, 2021
sarayourfriend
force-pushed
the
fix/clean-recursive-node-modules-compressed-size-check
branch
3 times, most recently
from
June 21, 2021 17:38
df85fd3
to
46b6484
Compare
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
fix/clean-recursive-node-modules-compressed-size-check
branch
2 times, most recently
from
June 23, 2021 13:12
fe8ca00
to
6f8df1a
Compare
ciampo
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM and follow the instructions from preactjs/compressed-size-action#60 🚀
sarayourfriend
deleted the
fix/clean-recursive-node-modules-compressed-size-check
branch
June 23, 2021 18:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following developit's advice from here: preactjs/compressed-size-action#59 (comment)
How has this been tested?
Compressed size check action should continue to pass.
Types of changes
Bug fix/adjust compressed size check to work with lerna.
Checklist:
*.native.js
files for terms that need renaming or removal).