Customize Widgets: Fix block toolbar deselection when clicking scrollbar #32762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
commented
Jun 17, 2021
packages/customize-widgets/src/components/customize-widgets/use-clear-selected-block.js
Show resolved
Hide resolved
|
Size Change: -1 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
talldan
commented
Jun 17, 2021
| @@ -16,11 +16,6 @@ | |||
| transition: border-color 0.1s linear, box-shadow 0.1s linear; | |||
| @include reduce-motion("transition"); | |||
|
|
|||
| // Allow overflow on desktop. | |||
| @include break-small() { | |||
| overflow: inherit; | |||
There was a problem hiding this comment.
I wonder if this started causing issues because the component was nested under a different element. Strikes me that inherit should probably be avoided in the root of react component styles, because it couples the component to its parent.
There was a problem hiding this comment.
Had to revert this as it causes lots of tests to fail, though I can't see why. I'm unable to reproduce the issues the tests are having.
c3c4bb4 to
9593f6a
Compare
9593f6a to
08e451b
Compare
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
…bar (#32762) * Remove overflow inherit style * Switch to using mousedown instead of focusin * Revert style change
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
…bar (#32762) * Remove overflow inherit style * Switch to using mousedown instead of focusin * Revert style change
This was referenced Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://core.trac.wordpress.org/ticket/53400
With scrollbars set to show 'always' in Mac OS, trying to drag the scrollbar on the top block toolbar resulted in a block deselection.
This PR also fixes the vertical scrollbar that shows sometimes in the top toolbar mode
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).