Created author block. #3250

jorgefilipecosta · 2017-10-30T23:48:50Z

Description

This PR aims to add an author block, as specified in issue #1844..

Screenshots

To test

Add an author block, try to hide each of three options see the hiding attribute works as expected in the editor and when saving the post.
Try each of the alignment options verify the alignment looks ok.

Notes

The single-author component is going to be reused in author blocks.
A max-width of 50% was added when align is not center, because without the post after published does not look as in the editor and in fact, no difference is noticeable when compared to center alignment.

codecov · 2017-11-01T13:46:20Z

Codecov Report

Merging #3250 into master will decrease coverage by 7.47%.
The diff coverage is 20.83%.

@@            Coverage Diff             @@
##           master    #3250      +/-   ##
==========================================
- Coverage   38.49%   31.01%   -7.48%     
==========================================
  Files         286      235      -51     
  Lines        6942     6545     -397     
  Branches     1273     1164     -109     
==========================================
- Hits         2672     2030     -642     
- Misses       3590     3788     +198     
- Partials      680      727      +47

Impacted Files	Coverage Δ
blocks/single-author/index.js	`0% <0%> (ø)`
editor/selectors.js	`94.41% <100%> (+0.91%)`	⬆️
blocks/library/author/block.js	`11.76% <11.76%> (ø)`
blocks/library/author/index.js	`40% <40%> (ø)`
components/notice/index.js	`0% <0%> (-100%)`	⬇️
blocks/url-input/button.js	`0% <0%> (-100%)`	⬇️
components/panel/row.js	`0% <0%> (-100%)`	⬇️
blocks/block-controls/index.js	`0% <0%> (-100%)`	⬇️
components/keyboard-shortcuts/index.js	`0% <0%> (-85.72%)`	⬇️
components/slot-fill/provider.js	`5% <0%> (-85.33%)`	⬇️
... and 304 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a218f...cd9423a. Read the comment docs.

karmatosed · 2017-12-14T21:44:02Z

As you came so far with this, want to fix up the issues and we can review @jorgefilipecosta ?

jorgefilipecosta · 2017-12-15T14:51:37Z

Hi @karmatosed, I rebased this, the automated tests were failing because of a change in our mechanism. I think this is ready for a review/testing.

aduth · 2017-12-15T15:07:14Z

blocks/library/author/index.js

+
+	category: 'widgets',
+
+	keywords: [ __( 'author' ) ],


You shouldn't need to define this keyword, since inserter search already uses the "title" field for search, and it's unlikely "Author" would be translated differently than "author".

aduth · 2017-12-15T15:10:16Z

blocks/library/author/block.js

+		} )
+	),
+	withAPIData( ( props ) => ( {
+		author: `/wp/v2/users/${ props.postAuthorId }`,


We're going to have permissions issues here for non-administrator users:

https://github.com/WordPress/wordpress-develop/blob/53f1c74e1c55910f9b7e4aebc8033571d3e52df8/src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php#L357-L384

I'm not sure how we'd address this.

This is a complex problem, that probably will be faced in other blocks.
I'm seeing two possible paths:
We conclude that this information should be available in the API and we create a patch for that. To me author name, description and avatar look like information that can be public.
We conclude that this information should not be public. In this case, we need to have a mechanism to only allow the author of the post to add this block. And we need a state that shows some message like "No permissions to display this block in the editor, please use the preview to visualize this block content" when the post is being edited by a user that is not admin or post author.

aduth · 2017-12-15T15:11:26Z

blocks/library/author/index.php

+ */
+function gutenberg_render_block_core_author( $attributes ) {
+	$align = 'center';
+	if ( isset( $attributes['align'] ) && in_array( $attributes['align'], array( 'left', 'right', 'full' ), true ) ) {


The isset here may be unnecessary, since we'd always assume it to be set.

aduth · 2017-12-15T15:12:45Z

blocks/single-author/style.scss

+		text-align: center;
+	}
+	p:after {
+			content: "";


Tabbed too far here.

aduth · 2017-12-15T15:13:12Z

blocks/test/fixtures/core__author.json

+        "name": "core/author",
+        "isValid": true,
+        "attributes": {
+			"hideBio": false,


Wonder why tabbing is off here, since this is generated. 🤷‍♂️

Here in github it looks like it has wrong tabbing but I checked in the editor the tabs were right, looks like this is related with github visualization.

It's a difference of tabs and spaces. Depending on how your editor is configured, it might be showing tabs as 4 spaces, appearing aligned.

aduth · 2017-12-15T15:13:42Z

blocks/test/fixtures/core__author___hide.html

@@ -0,0 +1 @@
+<!-- wp:core/author {"hideBio":true,"hideAvatar":true,"hideName":true} /-->


The wp:core/ is no longer necessary, and can be seen as stripped in the serialized version.

I changed wp:core/author to wp:author, but unfortunately, some of our PHP tests started failing (possible to see in our CI). I probably misunderstood the change :(

aduth · 2017-12-15T15:14:34Z

editor/selectors.js

+ * @param  {Object} state Global application state
+ * @return {Number}      ID of post author
+ */
+export function getCurrentPostAuthor( state ) {


Opens a question as to whether we want granular selectors for every single property of a post, or if it's reasonable to expect a developer to use getCurrentPost( state ).author directory (or alternatively, a getCurrentPostAttribute( state, key ) selector?).

aduth · 2017-12-15T15:31:20Z

blocks/library/author/index.js

+
+	keywords: [ __( 'author' ) ],
+
+	supportHTML: false,


This will need to be rebased per #4014

karmatosed · 2018-03-07T18:00:14Z

Can we rebase this? Just so we can review.

westonruter · 2018-03-19T17:35:50Z

blocks/library/author/block.js

+export default compose(
+	connect(
+		( state ) => ( {
+			postAuthorId: getEditedPostAttribute( state, 'author' ),


See also https://github.com/WordPress/gutenberg/pull/5602/files#r175522235 for a proposal where I think we could formalize the dependence on this post context via a new attribute source type.

karmatosed · 2018-05-10T19:14:35Z

Do we still want this open or close?

jorgefilipecosta · 2018-05-11T09:49:18Z

Sorry, @karmatosed missed your ping. I think this PR is not relevant I will close. During next phases, we can reopen it.

jorgefilipecosta added [Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take labels Oct 30, 2017

jorgefilipecosta self-assigned this Oct 30, 2017

jorgefilipecosta force-pushed the add/author-block branch 4 times, most recently from a9e4cc2 to 24ceba1 Compare November 1, 2017 13:46

jorgefilipecosta added Needs Design Feedback Needs general design feedback. and removed [Status] In Progress Tracking issues with work in progress labels Nov 1, 2017

jorgefilipecosta requested review from youknowriad, mcsf, gziolo, aduth and ellatrix November 1, 2017 14:46

jorgefilipecosta changed the title ~~WIP - Created author block.~~ Created author block. Nov 1, 2017

jorgefilipecosta mentioned this pull request Nov 2, 2017

WIP Added authors block. #3323

Closed

jorgefilipecosta force-pushed the add/author-block branch from 7dd8f34 to fa32f34 Compare December 7, 2017 22:24

jorgefilipecosta force-pushed the add/author-block branch from fa32f34 to ec7be13 Compare December 15, 2017 12:48

aduth reviewed Dec 15, 2017

View reviewed changes

jorgefilipecosta force-pushed the add/author-block branch from cd9423a to 61f6d36 Compare December 18, 2017 19:53

Created author block.

0466055

jorgefilipecosta force-pushed the add/author-block branch from 61f6d36 to 0466055 Compare December 19, 2017 14:36

gziolo removed their request for review January 27, 2018 18:39

westonruter mentioned this pull request Mar 19, 2018

Add Server Side Render component. #5602

Merged

3 tasks

westonruter reviewed Mar 19, 2018

View reviewed changes

jorgefilipecosta closed this May 11, 2018

jorgefilipecosta deleted the add/author-block branch May 11, 2018 09:49

westonruter mentioned this pull request Apr 4, 2019

[AMP Stories] Editor includes all additional blocks to satisfy the Fandom and Travel story creation needs ampproject/amp-wp#2007

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created author block. #3250

Created author block. #3250

jorgefilipecosta commented Oct 30, 2017 •

edited

Loading

codecov bot commented Nov 1, 2017 •

edited

Loading

karmatosed commented Dec 14, 2017

jorgefilipecosta commented Dec 15, 2017

aduth Dec 15, 2017

aduth Dec 15, 2017

jorgefilipecosta Dec 18, 2017

aduth Dec 15, 2017

aduth Dec 15, 2017

aduth Dec 15, 2017

jorgefilipecosta Dec 18, 2017

aduth Dec 19, 2017

aduth Dec 15, 2017

jorgefilipecosta Dec 18, 2017

aduth Dec 15, 2017

aduth Dec 15, 2017

karmatosed commented Mar 7, 2018

westonruter Mar 19, 2018

karmatosed commented May 10, 2018

jorgefilipecosta commented May 11, 2018

		@@ -0,0 +1 @@
		<!-- wp:core/author {"hideBio":true,"hideAvatar":true,"hideName":true} /-->

Created author block. #3250

Created author block. #3250

Conversation

jorgefilipecosta commented Oct 30, 2017 • edited Loading

Description

Screenshots

To test

Notes

codecov bot commented Nov 1, 2017 • edited Loading

Codecov Report

karmatosed commented Dec 14, 2017

jorgefilipecosta commented Dec 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karmatosed commented Mar 7, 2018

Choose a reason for hiding this comment

karmatosed commented May 10, 2018

jorgefilipecosta commented May 11, 2018

jorgefilipecosta commented Oct 30, 2017 •

edited

Loading

codecov bot commented Nov 1, 2017 •

edited

Loading