Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force allowed blocks innerBlocks allowedBlocks setting #32435

Closed
wants to merge 1 commit into from
Closed

Force allowed blocks innerBlocks allowedBlocks setting #32435

wants to merge 1 commit into from

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jun 3, 2021 •
edited
Loading

Description

See the Issue #32436.

Depends on whether that issue is validated, this PR aims to fix it by existing early if a given parent block has excluded a block from it's <InnerBlocks> allowedBlocks list.

How has this been tested?

Follow the exact same reproduction steps as on the Issue but this time with this branch applied. You should see that the allowedBlocks are respected.

Screenshots

Screen Shot 2021-06-03 at 17 19 26

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@ramonjd ramonjd added [Package] Block editor /packages/block-editor [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Type] Bug An existing feature does not function as intended labels Aug 26, 2021
@getdave
Copy link
Contributor Author

getdave commented Sep 3, 2021

Not pursuing this for now.

@getdave getdave closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix will be requested when the pull request is marked ready for review ellatrix is a code owner

Assignees

@getdave getdave

Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getdave @ramonjd