Components: update <Card /> implementation to g2 version
#32243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f400b7 to
bdb3aed
Compare
27d6113 to
312e7aa
Compare
ciampo
commented
May 28, 2021
ciampo
commented
May 28, 2021
ciampo
commented
May 28, 2021
|
Size Change: +212 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
ciampo
commented
May 28, 2021
ciampo
commented
May 28, 2021
ciampo
commented
May 28, 2021
<Card /> and replace current implementation
ciampo
commented
May 28, 2021
ciampo
commented
May 28, 2021
ciampo
commented
May 28, 2021
cb08d29 to
39495c2
Compare
<Card /> and replace current implementation<Card /> implementation to g2 version
ciampo
commented
Jun 3, 2021
- Update import paths - Keep old implementation temporarily in `src/card-old`
- Add `size` and `isShady` - Add deprecated `isElevated` - Rework padding system - ...and more
983923a to
eabc0ef
Compare
tyxla
reviewed
Jun 9, 2021
I'll try my best. I'm closing this PR for now, I will post updates once the split PRs are ready |
7 tasks
|
Split PRs (will be updated as they are created):
|
This was referenced Jun 9, 2021
Merged
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<Card />component with the new g2 implementation (which, prior to this PR, sits inpackages/components/src/ui/card.isElevatedprop on the<Card />component is being soft-deprecated in favour of a newelevationprop (which enables fine-grain control on the card's elevation)<CardMedia />component didn't exist in the g2 implementation and was created directly in this PR (pretty much a 1:1 with the current version)<CardDivider />component didn't exist in the g2 implementation and was created directly in this PR. Although its APIs are the same as the old version, internally it now extends the<Divider />componentsizeproperty:nonepaddingassociated to thesizeproperty has slightly changed to match the spacing system used by other g2 components (used by<Card />,<CardBody />,<CardHeader />and<CardFooter />)Detailed action plan (used to track the PR's progress)
Replace the old implementation with the new from✅ui/folderMake project compile (fix imports, etc)✅Reconciliate APIs:✅Match new implementation with OLD APIs✅Add and deprecate✅isElevatedAdd✅sizeand propagate it to the sub componentsPropagate✅isBorderlessto sub componentsRemove the✅sizeproperty on CardHeaderRemove the✅CardInnerBodycomponentRefactor folder structure like Flex (one folder per component)✅Add missing subcomponents✅CardMediaCardDividerReplace Storybook story with a single story which includes✅<Card />and all of its subcomponents in one placeUpdate tests✅Update READMEs✅Update the CHANGELOG:✅Internal: "rewrote component's internals"✅External:✅isElevateddeprecation, addednoneas a value forsize, changed border color for header/footer/dividerSearch and update any component's usages across the codebase✅Remove dependencies from the✅/ui/folderPromote✅<Surface />component Components: promoteSurface#32439Promote✅<Scrollable />component Components: promoteScrollable#32446Make sure there's no other references to✅ui/apart from contextTesting instructions
CardStorybookCardStorybook:npm run storybook:devhttp://localhost:50240/?path=/story/components-card--default<Card />in the repo keep working as beforeScreenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).