-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete widget action #32079
Closed
Closed
Add delete widget action #32079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
tellthemachines
force-pushed
the
add/delete-widget-action
branch
from
May 26, 2021 23:45
ca9cb81
to
5b8bac2
Compare
This looks perfect but it will need to happen in core now that the widgets endpoints have been moved there. |
Closing this as it needs to be done in core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #31126
Adds a
delete_widget
hook in the widgets REST API controller that runs when a widget is deleted.How has this been tested?
I'm not sure what is the best way to test this, tips appreciated!
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).