Build: Upgrade husky package to the latest version #32077
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @RhnSharma! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
@RhnSharma Husky 6.0.0 has a lot of changes. Can you migrate husky denoted in |
|
@shivapoudel Could you please explain what I need to do? |
|
Plese see the migration guide for husky here https://typicode.github.io/husky/#/?id=husky-4-to-6-cli |
|
@shivapoudel @talldan I migrated husky to version 6. How does this look? |
|
I haven't tested it yet, but it looks like everything is on track. Can you explain why |
|
@gziolo Inside the @RhnSharma Can you also add |
|
@shivapoudel I added the prepare script to package.json. Please take a look at it and let me know if this needs any changes. |
There was a problem hiding this comment.
@gziolo @RhnSharma Each step required for husky migration exists and looks good on my end 👍
|
Congratulations on your first merged pull request, @RhnSharma! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
* With husky 7.0.0, .husky/.gitignore is now unnecessary and can be removed Ref: #32077 (comment) CC @gziolo * Declare files that will always have LF line endings on checkout * Git ignore Windows specific files and remove composer vendor dir * Remove special handling for PHP files from .gitattributes * Unfortunately vendor dir is required to pass the test Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
* With husky 7.0.0, .husky/.gitignore is now unnecessary and can be removed Ref: #32077 (comment) CC @gziolo * Declare files that will always have LF line endings on checkout * Git ignore Windows specific files and remove composer vendor dir * Remove special handling for PHP files from .gitattributes * Unfortunately vendor dir is required to pass the test Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Fixes #31967
Hi @shivapoudel @talldan, how does this look?
Thanks