First pass at docs for the Widgets Block Editor #31577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +364 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Hey @noisysocks. I don't see that updated in this PR, so I think it may have been overwritten. IIRC, one of the toc.json or the manifest.json is updated manually and the other is auto-generated from that change. Given the manifest changes aren't present, that's probably the one that's auto-generated from the manually updated toc.json. |
|
Aha, oops, I updated |
…and the wording more consistent and less verbose
draganescu
approved these changes
May 8, 2021
There was a problem hiding this comment.
Made a few changes, not essential. The docs are great @noisysocks thanks for writing them!
This was referenced May 17, 2021
|
In the "Add a block transform" section of this doc, the example is using a "from" transform. Shouldn't this be a "to" transform, @noisysocks ? |
|
A If it were a |
|
Ok. I'm trying to add a transform in a legacy widget I developed years ago and I cannot get it to work either way (from or to) as it doesn't appear in the Transform dropdown. I must be doing something wrong. |
|
@mrleemon Feel free to share your transform code and I'll see if I can spot anything. |
|
Here it is: The block and the legacy widget have two boolean attributes: Thanks in advance |
|
@mrleemon The blocks array should be The block you're transforming to is indicated by the block definition that the transform appears within (and the block type specified in the This is the reverse of a |
|
Thanks, that was it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my first pass at some docs for the Widgets Block Editor. This checks off many of the items in #25759.
I'm not really familiar with how
docs/manifest.jsonworks so please let me know if I did something wrong there.