Update: stabilises GradientPicker and CustomGradientPicker components #31440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -279 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
…. Remove some experimental gradient abstractions form the block editor.
c5f8818 to
667c0c0
Compare
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Update: stabilizes GradientPicker and CustomGradientPicker components. The components have a very small API, follow the equivalent color components, and may be useful for plugin and block authors as a basis of a more complex interaction not covered by our supports hook.
This PR also removes some experimental gradient abstractions from the block editor. None of these abstractions is currently used by the editor ( the UI suffered some changes and now we don't have a panel just for gradients we have panels for colors and gradients PanelColorGradientSettings). These components also don't seem very useful and using the components we are now stabilizing would be very easy to achieve what they do.
I'm not stabilizing yet __experimentalColorGradientControl and __experimentalPanelColorGradientSettings. It is not clear yet if the support mechanism will cover everything and these components could be internal only. __experimentalColorGradientControl is only exposed as a way to share code between block editor and global styles components but it is not probably as it is something that is useful or should already be part of the public API.
Part of: #31416.
How has this been tested?
I verified gradients in cover and group block still work as expected.
I verified the gradient components still work on the site editor global styles panel.