Fix navigation screen collapsing regression. #31228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a sidenote, I don't recall whether the appender plus is meant to hide like it does here. I think it's meant to? But I wonder if we should make an exception and always show it here. @shaunandrews ? |
|
Size Change: +14 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Apr 27, 2021
|
Thanks a bunch! |
There's no other + button on the page, so my thinking is that it should always show. |
|
Right. Looking at the code, that missing appender doesn't appear to be a regression, and it doesn't seem trivial to bring it back. It might need a nav screen specific implementation. @draganescu is this something we should ticket, or is it a easy fix for you? |
|
Ticketed here: #31276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm afraid I introduced an issue in the navigtation screen with #30805, which removed the padding:
This PR fixes that:
It does so by putting the menu item padding in the navigation editor screen, where it arguably should be from the start, since it's effectively redesigning the block.
How has this been tested?
Please insert menu items and submenu items in the navigation screen and verify they work.
Checklist:
*.native.jsfiles for terms that need renaming or removal).