[RNMobile] Enable reusable block (preview mode) #31154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -331 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
# Conflicts: # packages/block-library/src/index.native.js
2 tasks
jd-alexander
approved these changes
May 3, 2021
There was a problem hiding this comment.
Hi @fluiddot Thanks all the work you have done on the Reusable blocks project. I performed a comprehensive behavior verification session guided by the testing instructions included in the PR and I was successfully able to confirm that the behavior implemented in all the child PRs that are linked work as expected 🚢 . To provide further clarity, below is a breakdown of all the tests I performed and the results of the said tests.
Devices
- iPhone 11, iOS 14.4
- Google Pixel 4 XL, Android 11 / API 30
WP Main App Versions
Testing
1. Present block content (preview mode) - iPhone 11, iOS 14.4
- WordPress.com site ✅
- Self-hosted site with Jetpack ✅
- Self-hosted site without Jetpack ✅
2. Additional improvements for rendering Reusable block
i. Preview content
- WordPress.com site ✅
- Self-hosted site ✅
ii. Deleted reusable block
- WordPress.com site ✅
- Self-hosted site ✅
iii. Recursive block rendering
- WordPress.com site ✅
- Self-hosted site ✅
| WordPress.com site | Self hosted site |
|---|---|
 |
 |
3. Add convert to regular blocks action to Reusable block
i. Convert to reusable blocks to regular blocks
- WordPress.com site ✅
- Self-hosted site ✅
ii. Undo/redo of reusable blocks conversion to regular blocks
- WordPress.com site ✅
- Self-hosted site ✅
|
Thank you very much @jd-alexander for the extensive review you've done in this PR, I really appreciate it ❤️ !
Good catch! I've been testing this and looks like on self-hosted the recursive block rendering has some issues. I'll investigate this further and open an issue 👍 . |
|
I've opened the issue regarding the problem with recursive block rendering on self-hosted sites. I'm afraid it's worse than I expected because on some cases it could even lead to a crash so I'm going to pause the merge of this PR until I find a solution. |
42 tasks
Was more than happy to @fluiddot 😄
I agree with pausing since some cases lead to a crash. Let me know if you need any help with testing etc, as well. 🙏🏾 |
6 tasks
|
@jd-alexander I opened this PR that contains these changes and besides limits the availability of the reusable block to only WP.com sites. The idea is to release this block to the sites we know it works and in the future fix the issue and enable it to self-hosted sites too. I'd appreciate it if you could take a look at it and once it's ready I'll close this in favor of that one, thanks 🙇 ! |
|
The reusable block has been enabled in this PR so we can safely close this one 🎊 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3440Description
This PR enables the Reusable block to be available for users.
How has this been tested?
This feature has been tested on previous PRs but we should do a final review, here are the testing instructions of the main related PRs that are already merged:
Present block content (preview mode)
PR: #25265
This was tested in the following 3 different scenarios:
WordPress.com site
Create a WordPress.com site or use an already created one.
Self-hosted site with Jetpack
Create a self-hosted site with Jetpack (I used https://jurassic.ninja/create/) or use an already created one.
Self-hosted site without Jetpack
Create a self-hosted site without Jetpack (I created a local one using this instructions) or use your own.
Additional improvements for rendering Reusable block
PR: #30966
NOTE: Reusable blocks can be managed by navigating to the "Reusable blocks page":
https://wordpress.com/types/wp_block/<YOUR_WPCOM_SITE_DOMAIN>https://<YOUR_SELF_HOSTED_SITE_DOMAIN>/wp-admin/edit.php?post_type=wp_blockHere are the steps for creating reusable blocks in the web version:
Option 1:
Option 2:
Preview content
Deleted reusable block
Recursive block rendering
Add convert to regular blocks action to Reusable block
PR: #31012
Undo/redo
It's important that we verify that the undo/redo actions work as expected when converting to regular blocks.
Screenshots
reusable-block-ios.mp4
reusable-block-android.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).