Packages: Fix linting warnings for core/block-editor store
#31146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +217 B (0%) Total Size: 1.49 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Apr 23, 2021
packages/components/src/mobile/link-picker/link-picker-results.native.js
Outdated
Show resolved
Hide resolved
|
We can land this PR as is when you revert a single change I highlighted :) There is also a tracking issue: #27088. |
core/block-editor store
gziolo
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes linting errors for string literals (
core/block-editor):warning Do not use string literals ( 'core/block-editor' ) for accessing @wordpress/data stores. Pass the store definition insteadThis brings the number of reported errors from 440 down to 407.
Checklist:
*.native.jsfiles for terms that need renaming or removal).