-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Block Library - Site Title]: Add default block after pressing enter at the end of Site Title #30996
Merged
ntsekouras
merged 1 commit into
trunk
from
fix/site-title-add-new-default-block-on-enter
Apr 20, 2021
Merged
[Block Library - Site Title]: Add default block after pressing enter at the end of Site Title #30996
ntsekouras
merged 1 commit into
trunk
from
fix/site-title-add-new-default-block-on-enter
Apr 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
An existing feature does not function as intended
[Package] Block library
/packages/block-library
[Block] Site Title
Affects the Site Title Block
labels
Apr 20, 2021
Size Change: +46 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, this is working well for me. Tested on Windows 10 with Edge, Firefox and Chrome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Site Title
Affects the Site Title Block
[Package] Block library
/packages/block-library
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #27831
Previously if you were editing the
Site Title
, pressing enter would do nothing. Noting that if you had just the block selected and not editing the content of the block, pressing enter would create a new block.Testing instructions
Site Title
block