Build Tooling: Update development tools to work with PostCSS (try 2) #30347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2021
|
Screen.Recording.2021-03-29.at.15.17.33.mov |
|
Size Change: +1.63 kB (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
Mar 29, 2021
2821581 to
d2acef7
Compare
gziolo
commented
Mar 30, 2021
Co-authored-by: Kai Hao <kevin830726@gmail.com>
d2acef7 to
4ec3226
Compare
|
npm.run.dev.movI also upgraded Storybook to the stable version: Thank you @gwwar and @kevin940726 for help, much appreciated 🥇 |
kevin940726
reviewed
Apr 8, 2021
|
Reserving this comment for testing:
|
gwwar
approved these changes
Apr 9, 2021
|
I hope it goes smoothly this time, and let's say hello to Storybook 6.2 🎉 |
|
I was seeing my changes not picked up. However before reporting this, I tested |
|
The above fixed the issue for me on the branch in which I was working. However I'm seeing npm run dev not working on this branch, despite being freshly rebased, and having run the nuclear reinstall: #30805 |
It must be related to the special handling that individual blocks have like |
|
I was using a non block theme. But switching to a block theme did not make it work, I'm afraid. |
|
That means it doesn't work in both cases. That's good feedback. So it looks like it generally works with CSS but might not work for the block library at all. |
|
Potentially. Feel free to try that branch, and make a change to the navigation block such as: If you add that to a stylesheet after having started npm run dev, it should add red borders everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27028.
Previous attempt: #27821.
This should allow to use @wordpress/scripts with PostCSS 8 but doesn't actually require it since it doesn't have it as a dependency at all.
See also https://github.com/webpack-contrib/postcss-loader/blob/v4.1.0/CHANGELOG.md
This PR also further improves the watch options for webpack build as tried in #30343 that caused the revert of #27821.
I also upgraded Storybook to the latest version:
6.2.5(it was rc.8 before).How has this been tested?
npm run devandnpm run buildstill work properly,Create Block still build correctly. Testing is a bit cumbersome but it follows what happens on CI (https://github.com/WordPress/gutenberg/blob/master/bin/test-create-block.sh):
npx wp-create-block esnext-example --no-wp-scriptscd esnext-example../node_modules/.bin/wp-scripts startbuildfolder.../node_modules/.bin/wp-scripts buildbuildfolder.npm run devfor Gutenberg works as expected.Checklist: