Keep submenus open onselect in the editor. #29713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Looks like this one also fixes a small regression with submenus in trunk, so it would be good to land. |
gwwar
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Tests well for me @jasmussen and feels much better ! If folks were in agreement with the behavior change this should be good to go.
wp-env is having some issues, causing CI to fail, so @jasmussen you may want to hold off on merging until that's fixed.
submenuopen.mp4
|
@jasmussen Would appreciate if you can test the navigation editor with a non FSE theme until #28874 is resolved. At the moment it's not possible for you to tell if the navigation editor is working as expected with that bug while using TT1-blocks. (but thank you for testing it 😄 ) |
c424eb1 to
db8fc3e
Compare
|
Thank you for the clarification. I tested in TwentyFourteen, and the post editor is the same:
I did notice the nav screen in this PR diverged from trunk, but that was fixed after a rebase. So now they look the same. Trunk:
This branch;:
Merging after the checks pass. Thanks again. |
|
Awesome, thank you for re-testing 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the navigation block CSS a little bit more, refines a width rule for submenus, and separates style vs. editor CSS slightly better, keeping the focus-within behavior on the frontend, but adding is-selected to the editor view.
The net result is a little less CSS, fewer rules, and easier editing in the editor.
Before, editor:
Before, frontend:
After, editor:
After, frontend:
This PR should not affect the separate editor. Before:
After:
How has this been tested?
Please test a navigation menu, frontend and editor, with menu items and submenu items.
Verify that menu items have an appropriate minimum width, and work well with tabbing and clicking in the editor. Notably you should now be able to click a submenu item, then click elsewhere to set focus there, and the submenu should remain open.
Checklist: