[RNMobile] Simplify media insertion flow Part 2 - media upload #29547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +89 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
6 tasks
7 tasks
guarani
reviewed
Mar 4, 2021
guarani
reviewed
Mar 9, 2021
…nto rnmobile/simplify_image_insertion_flow-media-upload
…on (#29548) * Track the clientId of the block that is inserted. * implemented auto opening utilizing last block inserted from the store * added dismissal support for the auto opening picker to the UI tests. * Updated Dismiss button in closePicker function to Cancel
ee4d502
into
rnmobile/simplify_image_insertion_flow-redux-changes
|
👋 @jd-alexander ! I noticed that the PR description here says:
I also noticed that #29546 is still open. Wondering if that other PR should be closed or perhaps we should clarify/amend the description here? Not a big deal, I was just a bit confused. |
@mchowning yes, this comment needs removal. I will do that now. Sorry for the confusion.
Yes, so that PR is still open because even though all the child PRs have been merged into it base/parent PR, we ended up having to do a refactor to resolve some other issues that were discovered during the final review process. So now #30123 will be merged into #29546 once the cleanup there is complete. |
jd-alexander
added a commit
that referenced
this pull request
Apr 20, 2021
* created actions for adding and clearing last inserted block event. * added reducer for determining new state based on the action * added selector to query the state for the last block inserted * [RNMobile] Simplify media insertion flow Part 2 - media upload (#29547) * added autoOpenMediaUpload prop to the MediaPlaceholder * Added the auto-opening capabilities to the MediaUpload component. * Added documentation for the new autoOpenMediaUpload prop * renamed autoOpenMediaUpload to autoOpen in the MediaUpload component. * [RNMobile] Simplify media insertion flow - Part 3 component integration (#29548) * Track the clientId of the block that is inserted. * implemented auto opening utilizing last block inserted from the store * added dismissal support for the auto opening picker to the UI tests. * Updated Dismiss button in closePicker function to Cancel * Added release notes for auto-opening. * [RNMobile] Refactor simplify media flow redux store changes (#30123) * Moved the last block inserted actions from editor to the block-editor * Moved the last block inserted reducer from editor to the block-editor * Moved the last block inserted selector from editor to the block-editor * Fixed es-lint error. * Moved last block inserted actions test from editor to the block-editor * Moved last block inserted reducer test from editor to the block-editor * Moved last block inserted selector test from editor to the block-editor * Moved all calls to last block inserted from editor to block-editor * last block inserter usage in menu native migrated : editor to block-editor * [RNMobile] Refactor: Simplify media flow redux migration (#30238) * Add meta argument to insertBlock action * Add inserter menu source * Update last block inserted reducer Instead of using specific actions for tracking the last block inserted, it uses the actions related to the insertion flow. * Add get last block inserted selector * Refactor gallery edit component withSelect and withDispatch logic has been refactored to use useSelect and useDispatch hooks * Refactor image edit component wasBlockJustInserted is now calculated with getLastBlockInserted * Refactor video edit component wasBlockJustInserted is now calculated with getLastBlockInserted * Fix reset blocks action in last block inserted reducer * Add source param to wasBlockJustInserted selector * Simplify withSelect part of video block * Removed add/clear last block inserted actions and tests due to refactor * Removed addLastBlockInserted from the insert menu's onPress. * rewrote the tests for the lastBlockInserted reducer. * rewrote tests for wasBlockJustInserted selector. * optimized clientId * removed unneeded clientId. * put the expectedSource inside the test meta object. * used expectedState insted {} for state related tests. * used expectedState instead {} for state related tests. * removed parentheses from describe name. * return the same state instead of empty state. * made changes to test name so its intent is clearer. * made the insertion source optional. Co-authored-by: Carlos Garcia <fluiddot@gmail.com> * added wasBlockJustInserted prop needed after merge with trunk. * removed updateSelection from reducer so it's updated at all times. Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR wordpress-mobile/gutenberg-mobile#2700Was merged into Part 1
Description
These changes introduce auto-opening capabilities to the
MediaUploadcomponent. Once theautoOpenMediaUploadprop istruethen the picker opens.How has this been tested?
To test this behavior, you can add
autoOpenMediaUpload={ true }flag to theMediaPlaceholdercomponent of either theImage,VideoorGallerycomponent. This will allow auto-opening capabilities on iOS and Android when the block is inserted or rendered.Screenshots
Image
Types of changes
autoOpenMediaUploadprop in theMediaUploadandMediaPlaceholdercomponents.delayon iOS when opening the picker because it was observed that without it, the inserter's close behavior closes the picker while it's opening. I know we aren't fond of utilizingdelayin our UI code, so the only other option would be to somehow pass the dismissal event of theInserterbottom sheet down to theMediaUploadcomponent. I wasn't sure how to do that at a glance and I wasn't sure it was worth the effort since, I have seenTimeout/delayuse cases across the codebase, so a second opinion on this before merge would be helpful.Checklist: