Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image options are not visible in pop up on clicking replace button from Image block #29057

Closed
wants to merge 4 commits into from

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Feb 17, 2021

This is a more specific approach to fixing #28604, targeting only the popover in question and in a branch off of wp/5.6.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

This is a more specific approach to fixing #28604, targeting only the popover in question.
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the replace flows in Image, Media & Text and Video blocks and this fixes the issue ✅

@github-actions
Copy link

github-actions bot commented Feb 17, 2021

Size Change: -246 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/block-editor/style-rtl.css 10.9 kB -15 B (0%)
build/block-editor/style.css 10.9 kB -15 B (0%)
build/block-library/editor-rtl.css 8.97 kB -3 B (0%)
build/block-library/editor.css 8.97 kB -2 B (0%)
build/block-library/style-rtl.css 7.72 kB -31 B (0%)
build/block-library/style.css 7.72 kB -30 B (0%)
build/components/style-rtl.css 15.4 kB -35 B (0%)
build/components/style.css 15.3 kB -35 B (0%)
build/edit-post/style-rtl.css 6.42 kB -16 B (0%)
build/edit-post/style.css 6.4 kB -17 B (0%)
build/edit-site/style-rtl.css 3.85 kB -9 B (0%)
build/edit-site/style.css 3.85 kB -9 B (0%)
build/edit-widgets/style-rtl.css 3.13 kB -8 B (0%)
build/edit-widgets/style.css 3.13 kB -9 B (0%)
build/editor/style-rtl.css 3.84 kB -6 B (0%)
build/editor/style.css 3.84 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.6 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-library/index.js 144 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.77 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.7 kB 0 B
build/components/index.js 170 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12.2 kB 0 B
build/data-controls/index.js 684 B 0 B
build/data/index.js 8.62 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-site/index.js 21.6 kB 0 B
build/edit-widgets/index.js 26.6 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 42.7 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.35 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.61 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.23 kB 0 B

compressed-size-action

@tellthemachines
Copy link
Contributor

Closing this as we've identified the proper fix in #27777 and it has been cherry-picked into the 5.6 release branch.

@youknowriad youknowriad deleted the fix/core-52396 branch February 17, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants