Border Radius Support: Fix application of zero radius values #28998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
This worked for me in terms of being able to set the 0 radius, but for some reason the default radius doesn't show in the slider when you first add the image or reset the slider. The image shows the default radius setting, but slider shows 0:
|
Thanks for the review 👍 The original PR that contained this specific fix included an arbitrary property in the theme.json schema's supports for the default. This was a hack requiring the theme developer to have to manually add that property to match whatever value they added in the theme.json styles. They would also need duplicate it per context e.g. to have different radii for The FSE gets the merged global styles added to the state. From there they can be used to set defaults on controls. Unfortunately, at this stage we do not have access to those merged styles. In the next evolution of the block supports mechanism I'm hoping that will be addressed. So to not add new properties to the schema then have to make a breaking change in dropping them, I limited the scope of this PR to only fixing the application of |
glendaviesnz
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Look like a good solution to me based on the explanation of the reason for the approach in #28998 (comment)
|
I'm just testing as a learning exercise, so don't have much context on this but can verify that: ✅ I can apply a The default value in Which makes me wonder, do we need to set the default to |
|
Thanks @ramonjd for giving this a test.
If I understand your question correctly. In this instance the theme.json was only setting the default 50px border radius for testing so that we could visually see the application of the explicit |
apeatling
approved these changes
Mar 2, 2021
|
Size Change: +13 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes problem where explicitly setting a border radius of zero wasn't honoured #27667 (review)
Note: This splits out the fix for zero values from exploration on setting min/max values etc in #28541
How has this been tested?
Manually.
Testing instructions
Screenshots
Types of changes
Bug fix
Checklist: