Rename pageTemplates config to customTemplates in theme.json #28830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -373 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
|
Every time I see "page templates" or "custom templates" referenced I need to spend a few seconds figuring out what we mean in the context. The problem is that we have lots of things called "templates", is there any way we can make it a bit easier to understand that this refers to custom templates specifically for pages? |
|
This is not specifically for "pages", it can work with any custom post type, it just happens that the "pages" are the default CPT where these are applied if you omit the "postType" key. |
|
One thing I think we need to reconsider is where we declare templates and whether the template metadata could live in the template itself (as This feedback should not block this PR. |
oandregal
approved these changes
Feb 8, 2021
youknowriad
commented
Feb 8, 2021
| @@ -476,6 +477,24 @@ These are the current typography properties supported by blocks: | |||
|
|
|||
| [1] The heading block represents 6 distinct HTML elements: H1-H6. It comes with selectors to target each individual element (ex: core/heading/h1 for H1, etc). | |||
|
|
|||
|
|
|||
| ### Other theme metadata | |||
There was a problem hiding this comment.
Thanks for this @nosolosw
|
My understanding is that the
If this makes sense, I can help with this, if that's useful. |
|
Makes a lot of sense. That said, as said by @mtias we might explore finding ways to define these inline in the files themselves in the future. I guess validation would still be useful but implemented differently in that case. |
|
Created WordPress/theme-experiments#202 for updating TT1-blocks. |
6 tasks
10 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments in #27778 (review)
Testing instructions
about.html/custom.html... to theblock-templatesfolder.customTemplatesproperty to the root level ofexperimental-theme.jsonlike soMakes sure the the templates show up on the "page attributes" panel of the editor sidebar.