Refactor rich-text to match the react-hooks/exhaustive-deps eslint rules
#27963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +272 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jan 4, 2021
| wrapperProps: omit( wrapperProps, [ 'data-align' ] ), | ||
| }; | ||
| const memoizedValue = useMemo( () => value, Object.values( value ) ); | ||
| const wrapperPropsOmitAlign = omit( wrapperProps, [ 'data-align' ] ); |
There was a problem hiding this comment.
Won't this always return a new array?
There was a problem hiding this comment.
Just found out that doesn't that mean the original way of doing this also will create a new array for each render?
There was a problem hiding this comment.
Yes, you're right. It seems fine to just pass the each wrapper props and include the data attribute in that case.
ellatrix
reviewed
Jan 4, 2021
| * @param {Function} effect The effect callback passed to `useEffect`. | ||
| * @param {Array} deps The dependency array that is compared against shallowly. | ||
| */ | ||
| function useShallowCompareEffect( effect, deps ) { |
There was a problem hiding this comment.
Why do we need new APIs just to work around the rule? Why can't we disable the rule for this particular instance?
I don't understand the need to introduce new APIs at all in this PR, unless it's going to be used in multiple places. Maybe we should just focus on fixing the dependencies in this PR?
There was a problem hiding this comment.
Hmm, yeah it makes sense, not sure why I included it in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's the same as in #25064, I accidentally merged it into a wrong base branch. Since it's been a while, reopen this to get a fresh round of reviews.
How has this been tested?
react-hooks/exhaustive-depsrule by rebasing this branch onto Enable react-hooks/exhaustive-deps eslint rules #24914.npm run lint-jsTypes of changes
Bug fix
Checklist: