Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Use store definition instead of string for notices packages #27548

Merged
merged 3 commits into from
Dec 10, 2020

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Dec 7, 2020

Description

Part of #27088.

The goal of this PR is to replace all occurrences of core/notices as a store name with the store definition exposed from @wordpress/notices. It also removes no longer necessary bare imports for @wordpress/notices` package.

How has this been tested?

npm run test-unit
npm run lint-js
npm run test-e2e

Types of changes

Refactoring.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Package] Notices /packages/notices labels Dec 7, 2020
@gziolo gziolo self-assigned this Dec 7, 2020
@gziolo gziolo force-pushed the try/notices-store-refactor branch from aff1f56 to f489b69 Compare December 9, 2020 16:50
@gziolo gziolo marked this pull request as ready for review December 9, 2020 16:50
@github-actions
Copy link

github-actions bot commented Dec 9, 2020

Size Change: -37 B (0%)

Total Size: 1.21 MB

Filename Size Change
build/annotations/index.js 3.8 kB -2 B (0%)
build/block-directory/index.js 8.72 kB +4 B (0%)
build/block-editor/index.js 128 kB -22 B (0%)
build/block-library/index.js 149 kB -1 B
build/blocks/index.js 48.1 kB -3 B (0%)
build/components/index.js 172 kB -8 B (0%)
build/compose/index.js 10.2 kB +1 B
build/core-data/index.js 15.3 kB -3 B (0%)
build/data/index.js 8.97 kB +1 B
build/date/index.js 31.8 kB +2 B (0%)
build/edit-navigation/index.js 11.1 kB -2 B (0%)
build/edit-post/index.js 306 kB +7 B (0%)
build/edit-site/index.js 24.7 kB +5 B (0%)
build/edit-widgets/index.js 26.3 kB +4 B (0%)
build/editor/index.js 43.4 kB -22 B (0%)
build/format-library/index.js 6.74 kB +1 B
build/i18n/index.js 3.57 kB -1 B
build/reusable-blocks/index.js 2.92 kB +1 B
build/shortcode/index.js 1.69 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11.2 kB 0 B
build/block-editor/style.css 11.2 kB 0 B
build/block-library/editor-rtl.css 9.07 kB 0 B
build/block-library/editor.css 9.07 kB 0 B
build/block-library/style-rtl.css 8.35 kB 0 B
build/block-library/style.css 8.35 kB 0 B
build/block-library/theme-rtl.css 789 B 0 B
build/block-library/theme.css 790 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.3 kB 0 B
build/data-controls/index.js 827 B 0 B
build/deprecated/index.js 769 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.95 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/style-rtl.css 6.49 kB 0 B
build/edit-post/style.css 6.47 kB 0 B
build/edit-site/style-rtl.css 3.93 kB 0 B
build/edit-site/style.css 3.93 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/style-rtl.css 3.84 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.27 kB 0 B
build/html-entities/index.js 622 B 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keyboard-shortcuts/index.js 2.54 kB 0 B
build/keycodes/index.js 1.93 kB 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.31 kB 0 B
build/notices/index.js 1.82 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 13.4 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 2.84 kB 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo merged commit c7b6701 into master Dec 10, 2020
@gziolo gziolo deleted the try/notices-store-refactor branch December 10, 2020 06:02
@github-actions github-actions bot added this to the Gutenberg 9.6 milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Notices /packages/notices [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants