-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Use store definition instead of string for notices packages #27548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Notices
/packages/notices
labels
Dec 7, 2020
17 tasks
gziolo
force-pushed
the
try/notices-store-refactor
branch
from
December 9, 2020 16:50
aff1f56
to
f489b69
Compare
gziolo
requested review from
adamziel,
ajitbohra,
ajlende,
draganescu,
ellatrix,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
December 9, 2020 16:50
Size Change: -37 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #27088.
The goal of this PR is to replace all occurrences of
core/notices
as a store name with the store definition exposed from@wordpress/notices. It also removes no longer necessary bare imports for
@wordpress/notices` package.How has this been tested?
npm run test-unit
npm run lint-js
npm run test-e2e
Types of changes
Refactoring.
Checklist: