-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reusable blocks] Edit single instance at a time, cancel on escape key #27325
Conversation
Size Change: +90 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Tests appear to be failing because creating a new reusable block doesn't work properly. When you click "Add to Reusable blocks", the content appears to be erased (though if you stop editing the new reusable block, it will reappear. The problem is that the local state for a brand new reusable block isn't set properly. I guess it has something to do with how a newly-created reusable block is immediately put into edit mode. Everything else seems to be working correctly in this PR. Thanks for working on this. 👍 |
@ZebulanStanphill @paaljoachim I was about to rebase and fix the bugs, but it looks like this PR is obsolete now that reusable blocks are saved in the same way as template parts? I'm closing it, but feel free to reopen and comment if I'm wrong – I'm happy to get it across the line. |
Description
This PR reinstates the changes from #21427 that were reverted after making reusable blocks a separate package:
How has this been tested?
Go to post editor and confirm the two changes described above indeed work.
Types of changes
Bug fix
Checklist: