-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Better social links placeholder. #26953
Conversation
Size Change: +251 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
This works, but I don't think is addressing the underlying need. The three blank icons are confusing people, and they think they should be able to click on them and interact. How about making clicking on the blank icons interactive, the same behavior as the inserter. So when you click any of them it just opens the block inserter and when one is inserted you don't see the blank ones any more? Thoughts? To implement we need to create a customer renderAppender for the empty state, should be doable. An alternative is to use text there and just explain it "Click + to add a social link" |
Good thoughts. It's important to get this right because the setup state for blocks needs a new approach, one that isn't a white box. And if we can extrapolate a pattern here that works well, we can slowly apply it to additional blocks. Key for that to work is that the pattern is simple and relatively easy to replicate. Making each of the dots clickable is one good option, though if we do that it also needs some thought as to how that behavior can be made generic and reproducible for other blocks. Before that, I tried a small CSS patch just to get a feel for it:
What do you think? |
I like this much better, to me it seems more clear what to do when you click in. 👍 |
Should we try as is and then upgrade from there if it needs more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 We got tacit approval from @shaunandrews in his comment here
So yes, let's try it out. It is no less confusing 😁
09986c1
to
9de9c04
Compare
9de9c04
to
b5ad5c4
Compare
b5ad5c4
to
ca0ebc8
Compare
As we've explored and polished the social links placeholder to look more like the end result, there was recently some confusion around the dummy icons not being clickable:
This PR changes how the setup state works, so that the "plus" to append is overlaid on the placeholder itself: