Fix pullquote alignment for solid color style #26912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -13 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
tellthemachines
pushed a commit
that referenced
this pull request
Nov 17, 2020
6 tasks
tellthemachines
added a commit
that referenced
this pull request
Nov 17, 2020
* Fix pullquote alignment (#26912) * Fix/ie11 interface bugs (#26944) * Interface: fixed not showing footer in IE11 * Interface: prevent editor from overflowing browser window in IE11 * Interface: better solution to prevent editor from overflowing browser window in IE11 Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Ambient Hack <ambienthack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using default editor styles (theme styles disabled), the pullquote block's solid color style has an incorrect alignment in the editor. It ends up on the left of the page, while it should be aligned the same as other blocks with text centered.
This is the same issue we've seen previously with Image (#26376) and Quote (#26680), the block's styles are overriding the editor's margin auto rules.
How has this been tested?
Screenshots
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: