[Mobile] - MediaUpload - Remove dashicons and use icons instead

[geriux]

Gutenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#2660

Description

After this PR some dashicons were left to update causing the MediaUpload component to break on Android. This PR changes those icons to use some from the Icons library.

How has this been tested?

• Open the app on Android with metro running
• Add any block that allows to upload any media e.g Image block
• Tap on the placeholder
• Expect to see the picker without any crashes

Screenshots

Before	After

Note: The icons are slightly different. cc @iamthomasbishop

We were using for:

Image: https://developer.wordpress.org/resource/dashicons/#format-image
Video: https://developer.wordpress.org/resource/dashicons/#format-video

Update: there was also another icon that was set as default for the DropdownMenu component. This component is used in the Heading block but since this block passes its own icon, it wasn't causing issues. I updated it to prevent a future crash.

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[github-actions]

Size Change: +1 kB (0%)

Total Size: 1.17 MB

Filename	Size	Change
build/api-fetch/index.js	3.35 kB	+11 B (0%)
build/block-editor/index.js	128 kB	+20 B (0%)
build/block-editor/style-rtl.css	11.1 kB	-2 B (0%)
build/block-editor/style.css	11.1 kB	-1 B
build/block-library/editor-rtl.css	8.6 kB	+37 B (0%)
build/block-library/editor.css	8.6 kB	+37 B (0%)
build/block-library/index.js	135 kB	-2 B (0%)
build/components/index.js	167 kB	+19 B (0%)
build/edit-site/index.js	20.2 kB	+463 B (2%)
build/edit-site/style-rtl.css	3.51 kB	+206 B (5%)	🔍
build/edit-site/style.css	3.51 kB	+204 B (5%)	🔍
build/editor/index.js	45.5 kB	+13 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
build/a11y/index.js	1.14 kB	0 B
build/annotations/index.js	3.52 kB	0 B
build/autop/index.js	2.72 kB	0 B
build/blob/index.js	620 B	0 B
build/block-directory/index.js	8.53 kB	0 B
build/block-directory/style-rtl.css	943 B	0 B
build/block-directory/style.css	942 B	0 B
build/block-library/style-rtl.css	7.6 kB	0 B
build/block-library/style.css	7.59 kB	0 B
build/block-library/theme-rtl.css	741 B	0 B
build/block-library/theme.css	741 B	0 B
build/block-serialization-default-parser/index.js	1.78 kB	0 B
build/block-serialization-spec-parser/index.js	3.1 kB	0 B
build/blocks/index.js	47.5 kB	0 B
build/components/style-rtl.css	15.5 kB	0 B
build/components/style.css	15.5 kB	0 B
build/compose/index.js	9.42 kB	0 B
build/core-data/index.js	12 kB	0 B
build/data-controls/index.js	1.27 kB	0 B
build/data/index.js	8.43 kB	0 B
build/date/index.js	31.9 kB	0 B
build/deprecated/index.js	772 B	0 B
build/dom-ready/index.js	568 B	0 B
build/dom/index.js	4.42 kB	0 B
build/edit-navigation/index.js	10.4 kB	0 B
build/edit-navigation/style-rtl.css	868 B	0 B
build/edit-navigation/style.css	871 B	0 B
build/edit-post/index.js	306 kB	0 B
build/edit-post/style-rtl.css	6.24 kB	0 B
build/edit-post/style.css	6.23 kB	0 B
build/edit-widgets/index.js	17.5 kB	0 B
build/edit-widgets/style-rtl.css	2.8 kB	0 B
build/edit-widgets/style.css	2.8 kB	0 B
build/editor/editor-styles-rtl.css	492 B	0 B
build/editor/editor-styles.css	493 B	0 B
build/editor/style-rtl.css	3.8 kB	0 B
build/editor/style.css	3.8 kB	0 B
build/element/index.js	4.45 kB	0 B
build/escape-html/index.js	733 B	0 B
build/format-library/index.js	7.49 kB	0 B
build/format-library/style-rtl.css	547 B	0 B
build/format-library/style.css	548 B	0 B
build/hooks/index.js	1.74 kB	0 B
build/html-entities/index.js	621 B	0 B
build/i18n/index.js	3.55 kB	0 B
build/is-shallow-equal/index.js	709 B	0 B
build/keyboard-shortcuts/index.js	2.39 kB	0 B
build/keycodes/index.js	1.85 kB	0 B
build/list-reusable-blocks/index.js	3.02 kB	0 B
build/list-reusable-blocks/style-rtl.css	476 B	0 B
build/list-reusable-blocks/style.css	476 B	0 B
build/media-utils/index.js	5.12 kB	0 B
build/notices/index.js	1.69 kB	0 B
build/nux/index.js	3.27 kB	0 B
build/nux/style-rtl.css	671 B	0 B
build/nux/style.css	668 B	0 B
build/plugins/index.js	2.44 kB	0 B
build/primitives/index.js	1.34 kB	0 B
build/priority-queue/index.js	789 B	0 B
build/redux-routine/index.js	2.85 kB	0 B
build/rich-text/index.js	13.7 kB	0 B
build/server-side-render/index.js	2.61 kB	0 B
build/shortcode/index.js	1.7 kB	0 B
build/token-list/index.js	1.24 kB	0 B
build/url/index.js	4.06 kB	0 B
build/viewport/index.js	1.74 kB	0 B
build/warning/index.js	1.13 kB	0 B
build/wordcount/index.js	1.17 kB	0 B

_{compressed-size-action}

[chipsnyder]

Tested via the demo app. This is working well for me 👍

There seems to be one other location where this might come up but I'm unsure how to recreate that case. So I'll leave that up to you

[geriux]

Tested via the demo app. This is working well for me 👍

There seems to be one other location where this might come up but I'm unsure how to recreate that case. So I'll leave that up to you

Thanks for the review @chipsnyder! I updated the other icon as well to prevent future crashes.