-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Component: Apply effect on activeItem change #24958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psealock
added
the
[Feature] Navigation Component
A navigational waterfall component for hierarchy of items.
label
Sep 1, 2020
psealock
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
September 1, 2020 01:34
Size Change: +3 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
psealock
changed the title
apply effect on activeItem change
Navigation Component: Apply effect on activeItem change
Sep 1, 2020
joshuatf
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! This works as described and pre-approving with one optional nitpick
Co-authored-by: Joshua T Flowers <joshuatf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that direct manipulation of
activeItem
from outside results in a navigation. This PR changes theuseEffect
function to react to changes ofactiveItem
. To test, a button simulating a link to mimic outside navigation was added to the Story.How has this been tested?
npm run storybook:dev
Screenshots