Fix prop error and missing classes in Navigation component #24878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psealock
approved these changes
Aug 30, 2020
| <Text variant="body.small"> | ||
| <span>{ title }</span> | ||
| <Text | ||
| className="components-navigation__menu-item-title" |
There was a problem hiding this comment.
TIL you could do this. Me and several others have created parent spans just to add a class.
psealock
pushed a commit
that referenced
this pull request
Aug 31, 2020
* Don't trigger onClick prop when not provided * Add class names for external styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doesn't trigger the
onClickprop if not passed in favor of just using thehrefprop and doesn't triggerhrefif children exist.Also adds some missing classes for easier styling by the consumer.
Testing
npm run storybook:dev