Use css-in-js for styling in navigation component #24522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
psealock
reviewed
Aug 17, 2020
|
Thanks for the review, @psealock! Handled your feedback and removed quite a bit of styling to simplify this component further. Ready for another review. |
psealock
approved these changes
Aug 18, 2020
psealock
pushed a commit
that referenced
this pull request
Aug 25, 2020
* Migrate styles to css-in-js * Add spacing to navigation child items * Remove opinionated styling * Rename styling components
psealock
pushed a commit
that referenced
this pull request
Aug 26, 2020
* Migrate styles to css-in-js * Add spacing to navigation child items * Remove opinionated styling * Rename styling components
psealock
pushed a commit
that referenced
this pull request
Aug 31, 2020
* Migrate styles to css-in-js * Add spacing to navigation child items * Remove opinionated styling * Rename styling components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates styles from scss to css-in-js using emotion.
Screenshots
Testing
npm run storybook:dev.Navigationcomponent renders appropriately matching the design.