Fix block movers in navigator on experimental navigation page displaying horizontally #23779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
talldan
commented
Jul 8, 2020
| @@ -8,18 +8,15 @@ import { useViewportMatch } from '@wordpress/compose'; | |||
| */ | |||
| import BlockMover from '../block-mover'; | |||
|
|
|||
| function BlockMobileToolbar( { clientId, moverDirection } ) { | |||
| function BlockMobileToolbar( { clientId } ) { | |||
There was a problem hiding this comment.
I think this file can actually be deleted. I couldn't see any usage other than the native mobile version of it.
There was a problem hiding this comment.
Wouldn't deleting it break the native mobile app, then?
There was a problem hiding this comment.
Yeah, that's what I don't know. I don't think so as there's a separate index.native.js.
There was a problem hiding this comment.
Aha, gotcha. Yeah you're right that it probably can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two small issues from #23416.
BlockMobileToolbar(which is the web-based responsive mobile toolbar) had amoverDirectionprop, which wasn't being used and didn't do anything, asBlockMoverhandles its own orientation so this can be omitted.BlockMoverUpButtonandBlockMoverDownButtonare both used in the block navigator on the experimental navigation page. The prop for these components should have been renamed toorientationfrom__experimentalOrientationbut was somehow missed. This fixes an issue where the block movers in the navigator are sometimes shown horizontally instead of vertically—the prop is used to force the movers to display vertically.How has this been tested?
Screenshots
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: