Inserter: Render menu as content of Popover #2364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where clicking the Inserter button in content causes the menu to appear overlapping the button, rather than above it. The issue is described at #2323 (comment):
This pull request merely extracts most of the 26b75c8 commit that was already slated for #2323 while other requested changes are in-progress there.
Testing instructions:
This is most obvious for inserter menu which opens upwards, meaning it must be for a post which has enough content to allow vertical upward space to open. Try the Demo content or a new post with at least a couple blocks added.
Verify that the content inserter menu opens upward above button: