Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Test ] Current navigation screen status #22745

Closed
wants to merge 56 commits into from

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented May 29, 2020

Description

This PR will never be merged.
Do not code review this PR.

This is a mashup of all open PRs that add features or fix problems to advance the experimenal navigation screen. The new things are:

  • default appender look
  • delete operation for entities
  • delete menus through entities
  • delete menu items
  • batch create/update/delete for menu items
  • navigator item customizable menu
  • format index and category index link types
  • setting for automatic new page adding
  • appender default text includes default block name
  • the URL in links is dynamic

@github-actions
Copy link

github-actions bot commented May 29, 2020

Size Change: +1.33 kB (0%)

Total Size: 1.12 MB

Filename Size Change
build/annotations/index.js 3.62 kB +1 B
build/api-fetch/index.js 3.4 kB -3 B (0%)
build/block-editor/index.js 106 kB +1 B
build/block-editor/style-rtl.css 11.7 kB +292 B (2%)
build/block-editor/style.css 11.7 kB +289 B (2%)
build/block-library/index.js 126 kB +72 B (0%)
build/components/index.js 193 kB -3 B (0%)
build/core-data/index.js 11.8 kB +312 B (2%)
build/edit-navigation/index.js 8.36 kB +110 B (1%)
build/edit-navigation/style-rtl.css 981 B +103 B (10%) ⚠️
build/edit-navigation/style.css 981 B +105 B (10%) ⚠️
build/edit-site/index.js 15 kB -3 B (0%)
build/editor/index.js 44.8 kB +52 B (0%)
build/list-reusable-blocks/index.js 3.12 kB +1 B
build/media-utils/index.js 5.3 kB +1 B
build/primitives/index.js 1.5 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.75 kB 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-library/editor-rtl.css 7.87 kB 0 B
build/block-library/editor.css 7.88 kB 0 B
build/block-library/style-rtl.css 7.69 kB 0 B
build/block-library/style.css 7.68 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/components/style-rtl.css 19.5 kB 0 B
build/components/style.css 19.5 kB 0 B
build/compose/index.js 9.31 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.46 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.11 kB 0 B
build/edit-post/index.js 302 kB 0 B
build/edit-post/style-rtl.css 5.43 kB 0 B
build/edit-post/style.css 5.43 kB 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/index.js 8.83 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@karmatosed
Copy link
Member

First, this is catching a lot of the little hitches, so thank you so very much there. Just to recap what we see now:

image

I think over to and fro's here, I would like to get this merged as soon as possible to then refine. There are a few things I would like resolved, but they aren't blockers to merge.

  • The spacing on 'add new top level' seems tight. Maybe a little more line-height could ease that?
  • When I added a new link it appeared above the last one, this felt weird and here is what happened:

2020-05-29 15 31 28

  • Saving twice without a change the second time got me this:

image

If any of the above need separate issues let me know.

As far as things to explore once this is merged and I will create issues for each now.

  • Add as top-level: perhaps we can have this in the block ellipsis over below the block? I'd love input on that in an issue once this is merged.
  • The full title being 'add navigation link', because of the way it's styled that really distracts me right now. I think this needs to either reopen a prior discussion or focus on new issue.
  • Should we remove the block navigator from toolbar as it feels an unexpected replication?

image

  • The 'add navigation link' also doesn't change based on the background color:

image

I will also make an issue out of the revised sub-nav adjustments that seem to have not been done, no worries we can catch those.

draganescu added 23 commits June 4, 2020 16:48
there is a missing state preservation when menus are changed on the menus editor component
adds a format search handler
adds a category search handler
hooks the new handlers in the search endpoint
updates LinkControl's fetchLinkSuggestions to handle formats and categories as well
also searches for category matches via term query and limits formats with no items
also implements an UI to set auto_add in the new menu editor
…m:WordPress/gutenberg into test/nav-screen-status"

This reverts commit ead8ab2, reversing
changes made to cfcecf5.
This reverts commit cba04f8.
…ithub.com:WordPress/gutenberg into test/nav-screen-status""

This reverts commit a8c10ff.
fixes after delete to check for existing menu before accessing props
fixes setting the new menuId after delete
adds a locations save message
@draganescu draganescu force-pushed the test/nav-screen-status branch from a2857cb to 11c42fe Compare June 4, 2020 15:08
@draganescu draganescu closed this Jun 15, 2020
@youknowriad youknowriad deleted the test/nav-screen-status branch June 15, 2020 13:21
@youknowriad youknowriad restored the test/nav-screen-status branch June 15, 2020 13:21
@youknowriad youknowriad deleted the test/nav-screen-status branch June 15, 2020 13:21
@youknowriad youknowriad restored the test/nav-screen-status branch June 15, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants