-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Fetch: Support preloading in fetchAllMiddleware
.
#22510
Merged
epiqueras
merged 2 commits into
master
from
update/make-fetch-all-middleware-support-preloading
May 22, 2020
Merged
API Fetch: Support preloading in fetchAllMiddleware
.
#22510
epiqueras
merged 2 commits into
master
from
update/make-fetch-all-middleware-support-preloading
May 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
added
[Type] Enhancement
A suggestion for improvement.
[Package] API fetch
/packages/api-fetch
labels
May 20, 2020
epiqueras
requested review from
mmtr,
nerrad,
TimothyBJacobs and
youknowriad
as code owners
May 20, 2020 22:37
Size Change: +5 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
This looks like a reasonable change to me but something that could have some "hidden" impacts per experience :P. Can't think of any at the moment though, so we can ship and see. |
Can you approve it? |
youknowriad
approved these changes
May 21, 2020
epiqueras
force-pushed
the
update/make-fetch-all-middleware-support-preloading
branch
from
May 22, 2020 01:41
bb5807c
to
d6e69ab
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was noted by @TimothyBJacobs that our use of
per_page=-1
in preloading was not working as intended because a value of-1
there is a client-side affordance provided byfetchAllMiddleware
.This PR makes API fetch's
fetchAllMiddleware
requests go through the whole stack of middleware so that the server-inlined preloading middleware has a chance to resolve them.It also changes our preloading usage of
per_page=-1
toper_page=100
. This is the initial request sizefetchAllMiddleware
uses, so it will achieve what we were always intending.How to test this?
Verify nothing related to loading has changed.
Checklist: