Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Directory: Uninstall blocks that are not being used. #22452

Closed
wants to merge 11 commits into from

Conversation

StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented May 19, 2020

Description

Attempts to address: #22307

This PR reintroduces code that uninstalls blocks that are added to the document and not used when the post is published.

Part of this feature is exposing the installed blocks in the pre-publish panel.

Original Mockups:

Pre Publish

Screenshots

Currently not supporting "Details" under the author.

Description Screenshot
The user could have added 5 blocks, but only the ones that are used in the document show up in the pre-publish panel. Without Message

Types of changes

  • Introduces a plugin that ties into PluginPrePublishPanel slot.
  • Attaches an uninstall component to the state that uninstalls unused blocks when user publishes post.

TO DO

  • We need a better way to persist the installed blocks. We currently add it to the store. However, if the page is refreshed, the state is lost and blocks are not uninstalled.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@StevenDufresne StevenDufresne added the [Feature] Block Directory Related to the Block Directory, a repository of block plugins label May 19, 2020
@StevenDufresne StevenDufresne force-pushed the try/block-directory-uninstall-blocks branch from 14e212a to c811e0a Compare May 19, 2020 03:48
@github-actions
Copy link

github-actions bot commented May 19, 2020

Size Change: +1.38 kB (0%)

Total Size: 1.11 MB

Filename Size Change
build/annotations/index.js 3.62 kB +2 B (0%)
build/block-directory/index.js 8.19 kB +1.26 kB (15%) ⚠️
build/block-directory/style-rtl.css 897 B +107 B (11%) ⚠️
build/block-directory/style.css 899 B +108 B (12%) ⚠️
build/block-editor/index.js 105 kB -3 B (0%)
build/block-library/index.js 119 kB -1 B
build/block-serialization-default-parser/index.js 1.88 kB -1 B
build/components/index.js 182 kB -9 B (0%)
build/compose/index.js 6.67 kB -2 B (0%)
build/core-data/index.js 11.4 kB +1 B
build/data/index.js 8.43 kB +2 B (0%)
build/date/index.js 5.47 kB +2 B (0%)
build/deprecated/index.js 771 B -1 B
build/edit-navigation/index.js 6.6 kB -2 B (0%)
build/edit-post/index.js 302 kB -2 B (0%)
build/edit-site/index.js 12.8 kB -3 B (0%)
build/edit-widgets/index.js 7.73 kB +1 B
build/editor/index.js 44.3 kB -72 B (0%)
build/format-library/index.js 7.63 kB -1 B
build/hooks/index.js 2.13 kB +1 B
build/keyboard-shortcuts/index.js 2.51 kB -1 B
build/keycodes/index.js 1.94 kB -1 B
build/list-reusable-blocks/index.js 3.13 kB +1 B
build/media-utils/index.js 5.29 kB -4 B (0%)
build/notices/index.js 1.79 kB +1 B
build/nux/index.js 3.4 kB -1 B
build/plugins/index.js 2.56 kB +2 B (0%)
build/rich-text/index.js 14.8 kB -1 B
build/token-list/index.js 1.28 kB -1 B
build/url/index.js 4.02 kB +1 B
build/warning/index.js 1.14 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-editor/style-rtl.css 10.8 kB 0 B
build/block-editor/style.css 10.8 kB 0 B
build/block-library/editor-rtl.css 7.22 kB 0 B
build/block-library/editor.css 7.22 kB 0 B
build/block-library/style-rtl.css 7.48 kB 0 B
build/block-library/style.css 7.48 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/style-rtl.css 17.1 kB 0 B
build/components/style.css 17.1 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.11 kB 0 B
build/edit-navigation/style-rtl.css 857 B 0 B
build/edit-navigation/style.css 856 B 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/style-rtl.css 5.22 kB 0 B
build/edit-site/style.css 5.22 kB 0 B
build/edit-widgets/style-rtl.css 4.59 kB 0 B
build/edit-widgets/style.css 4.59 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/style-rtl.css 5.07 kB 0 B
build/editor/style.css 5.08 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ryelle
Copy link
Contributor

ryelle commented Jun 11, 2020

The changes in this PR have been split out & merged in #22752 & #22918, so I'm going to close this.

@ryelle ryelle closed this Jun 11, 2020
@ryelle ryelle deleted the try/block-directory-uninstall-blocks branch June 11, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants